Ignore fuzz tests in gas snapshot #10580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matYang
requested review from
chainchad,
javuto,
jkongie,
jmank88,
samsondav,
se3000 and
connorwstein
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149093018 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149746200 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6150395187 |
|
SonarQube Quality Gate
|
RensR
approved these changes
Sep 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make snapshotshould skip fuzz tests named according to best practices:testFuzz_\w{1,}?Although forge uses a static fuzz seed by default, flaky gas results per platform are still observed:
foundry-rs/foundry#5689
Until they fix the issue, including fuzz tests in snapshot results will result in flaky CI.
At this moment, this repo doesn't have fuzz tests. Tested the regex pattern in other repo, and in this repo by adding a
test_MockTest()to verify it is included in snapshot, andtestFuzz_MockTest()to verify it is not included in snapshot.