Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience flag to api token create #927

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

areed
Copy link
Contributor

@areed areed commented Apr 27, 2023

Name of feature:

--audience flag for step api token create

Pain or issue this feature alleviates:

Allows tokens to be issued for audiences besides the API gateway

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 27, 2023
@areed areed requested a review from maraino April 27, 2023 22:24
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove the swith for the moment.

command/api/token/create.go Outdated Show resolved Hide resolved
@areed areed force-pushed the areed/api-token-audience branch from 40b771c to b03e913 Compare April 27, 2023 22:35
@areed areed merged commit cbea039 into master May 1, 2023
@areed areed deleted the areed/api-token-audience branch May 1, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants