Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements for TPM attestation #915

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Small improvements for TPM attestation #915

merged 3 commits into from
Apr 14, 2023

Conversation

hslatman
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 14, 2023
@hslatman hslatman requested a review from maraino April 14, 2023 13:43
@hslatman hslatman enabled auto-merge April 14, 2023 15:17
maraino
maraino approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wonder if the change we made, calling the endpoint enroll instead of attest was right.

@hslatman hslatman merged commit 50a8ec8 into master Apr 14, 2023
@hslatman hslatman deleted the herman/tpm-improvements branch April 14, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hslatman @maraino