Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --certificate flag to step ssh fingerprint command #908

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Apr 12, 2023

With the changes from smallstep/crypto#207, the default behavior of step ssh fingerprint changes to be like the behavior of ssh-add (and similar tools). When a fingerprint is determined for an SSH certificate, the fingerprint will only include the bytes of the public key. With the --certificate flag, a user can create a fingerprint for the entire SSH certificate contents.

In general, users are most likely to want the behavior of ssh-add, so that's the default.

With the changes from smallstep/crypto#207,
the default behavior of `step ssh fingerprint` changes to be like
the behavior of `ssh-add` (and similar tools). When a fingerprint
is determined for an SSH certificate, the fingerprint will only
include the bytes of the public key. With the `--certificate` flag,
a user can create a fingerprint for the entire SSH certificate
contents.
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 12, 2023
@hslatman hslatman requested a review from a team April 12, 2023 13:43
Copy link
Contributor

@azazeal azazeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hslatman hslatman merged commit 7d26738 into master Apr 12, 2023
@hslatman hslatman deleted the herman/ssh-certificate-fingerprint branch April 12, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants