Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated usage package. Real one lives in cli-utils #904

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Apr 11, 2023

No description provided.

@dopey dopey requested review from tashian and maraino April 11, 2023 16:50
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 11, 2023
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks you need to remove blackfriday too. There seem to be small changes between both, probably related to linting warnings.

@dopey dopey requested a review from maraino April 11, 2023 17:23
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but there are differences between this files and the ones in cli-utils, the main one seems to be the --hugo flag. It is present in the cli, not in cli-utils. There are other differences probably related to linting, e.g.:

-	return cli.ShowAppHelp(ctx)
+	cli.ShowAppHelp(ctx)
+	return nil

@dopey dopey merged commit f525ec1 into master Apr 11, 2023
@dopey dopey deleted the max/remove-usage-pkg branch April 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants