Allow users to define certificate comment in agent #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
redrac
force-pushed
the
feature/allow_alternative_comment
branch
from
5d18129 to
9cc3c76
Compare
redrac
force-pushed
the
feature/allow_alternative_comment
branch
from
9cc3c76 to
8438c1a
Compare
Added a comment flag which allows users to set the comment for a certificate when it gets added to an agent. It defaults to current behavior if not set, which is it uses the subject as the comment. This allows users who interact with mutliple CAs with the same identity (email) to have multiple certificates in the agent. It also allows for use cases when users generate SSH certs with different extensions to load multiple certificates in their agent.
redrac
force-pushed
the
feature/allow_alternative_comment
branch
from
8438c1a to
befc7b4
Compare
dopey
reviewed
May 14, 2024
dopey
previously approved these changes
May 14, 2024
dopey
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Allow users to define certificate comment in agent
Pain or issue this feature alleviates:
Added a comment flag which allows users to set the comment for a certificate when it gets added to an agent. It defaults to current behavior if not set, which is it uses the subject as the comment. This allows users who interact with multiple CAs with the same identity (email) to have multiple certificates in the agent. It also allows for use cases when users generate SSH certs with different extensions to load multiple certificates in their agent. One use case we currently have is we allow users to add the github extension to their certificate, but we also disable agent forwarding. A user might want to get a regular (non-github extension) certificate into their agent for regular SSHing with agent forwarding while also having another certificate that has the github extension that cannot be forwarded anywhere in their agent. Currently they cannot do this because step complains about duplicate certificates (because the subject is always the comment).