Allow the define a custom tpm device #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to pass the device name option when initializing a tpm in the acme flow.
github-actions
bot
added
the
needs triage
hslatman
approved these changes
Oct 23, 2023
|
@maraino just came across https://github.com/smallstep/cli/pull/973/files, which I started working on a while ago. I think it does some of the same things you did in this PR, but I'm fine with merging yours. |
|
I'll merge this for the moment. I'm using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allows passing the device name option when initializing a TPM in the acme flow. It also allows passing the attestation-ca-url in the URI, as we can use a similar URI in
step kmscommands andstep ca certificate.