Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom error info on Windows eID PKCS missing dll dependecies #382

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

celuchmarek
Copy link
Member

@celuchmarek celuchmarek commented Jan 23, 2024

image

@celuchmarek celuchmarek requested a review from jsuchal January 23, 2024 15:49

public class PkcsEidWindowsDllException extends AutogramException {
public PkcsEidWindowsDllException(Exception e) {
super("Nastala chyba", "eID ovládač nie je možné použiť", "Nie je možné použiť eID ovládač pre podpisovanie občianskym preukazom. Pravdepodobne je potrebné do systému nainštalovať balík Microsoft Visual C++ 2015 <a href=\"https://www.google.com\">Redistributable</a>.\n\nAk to nepomôže, kontaktujte nás na [email protected]", e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toto asi nutne nemusí byť len Eid ovládač. Taktiež sa mi úplne nezdá ten Google link. Nedáme tam tento?

https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022

Prípadne ak sa bojíme že sa zmeni tak smerujeme
na nejaký náš web kde bude redirect (jedno malé html na služby.slovensko.digital) to spraví.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, asi so som niečo necommitol 😅 pravda, že asi to môže byť problém aj pri iných kartách, zmením. Viem spraviť aj redirect na ssd

@celuchmarek
Copy link
Member Author

Updatol som pôvodný screenshot.

@celuchmarek celuchmarek requested a review from jsuchal January 24, 2024 07:42
@celuchmarek celuchmarek merged commit f7f2407 into main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants