Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timedelta parsing breaking change #369

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix timedelta parsing breaking change #369

merged 3 commits into from
Nov 20, 2024

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Nov 15, 2024 •
edited
Loading

non-string default values were breaking when passed to re.Pattern.match introduced in #366

@ddelange ddelange mentioned this pull request Nov 15, 2024
Open
@ddelange
Copy link
Contributor Author

@sloria for a bugfix release

@sloria
Copy link
Owner

sloria commented Nov 15, 2024

Thanks for the pr. Will review when back from vacation next week

@sloria sloria merged commit deb0315 into sloria:main Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelange @sloria