Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RouteParser::getBasePath method (no changes to RouteParserInterface) #2859

Closed
wants to merge 1 commit into from
Closed

Adding RouteParser::getBasePath method (no changes to RouteParserInterface) #2859

wants to merge 1 commit into from

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Oct 4, 2019

This superseeds #2852 and partially resolves #2837

Only difference is that there are no changes to RouteParserInterface to not break backward compatibility.

@piotr-cz piotr-cz mentioned this pull request Oct 4, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 469f25e on piotr-cz:feature/routeparser-basepath-implementation into 80a52f7 on slimphp:4.x.

@adriansuter
Copy link
Contributor

That feels a bit hackish.

\Slim\Routing\RouteContext::getRouteParser() returns a \Slim\Interfaces\RouteParserInterface and therefore you would have to check if that is actually a \Slim\Routing\RouteParser and only then you could call that method.

@adriansuter adriansuter mentioned this pull request Oct 4, 2019
Merged
@l0gicgate
Copy link
Member

Fixed in #2860

@l0gicgate l0gicgate closed this Oct 5, 2019
@piotr-cz piotr-cz deleted the feature/routeparser-basepath-implementation branch October 6, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.x - Get base path within a route callback
4 participants
@piotr-cz @coveralls @adriansuter @l0gicgate