-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting the codebase from CoffeeScript to JavaScript #429
Comments
i absolutely think it makes sense to port from coffeescript to javascript (specifically ES2015). we had already discussed this as a task and wanted to complete it for the next major version bump. the reason its grouped that way is because we'd like to drop support for versions of node that are no longer being maintained and use new javascript features, which may change the API. |
thanks for making an issue for this though, in the next coming weeks i hope to publish a roadmap (in the form of GitHub milestones) to help bring transparency into what we have planned. in order for me to do that, we need to spend some time pruning the backlog of issues, which is no small feat. if you'd like to help, once those milestones are out, it will be easier to see where that help is most useful. |
@aoberoi sorry, I've just seen your reply. Let me know if and how I can help, thanks |
just taking notes: https://github.com/decaffeinate/decaffeinate |
Addresses the issue described in #15. In short, hubot-test-helper v1.8.0 depends on hubot-v3.0.0, both are rewrites from CoffeeScript to ES2015, and consequently hubot-slack adds Robot.react to a CoffeeScript- compatible wrapper function, leading to smoke and integration test failures. The implementation of slackapi/hubot-slack#429 (CoffeeScript-to-ES2015 rewrite) should include a fix that will eliminate the need for this workaround.
Something to put on the radar for this issue (though happy to file a new issue if desired): the The gory details are in mbland/slack-emoji-issues#15, but in a nutshell, There is a workaround, but it seems like the implementation of this issue should obviate the need for it: require('hubot-slack')
var CoffeeScriptCompatibleHubot = require('hubot')
var Hubot = require('hubot/es2015')
Hubot.Robot.prototype.react = CoffeeScriptCompatibleHubot.Robot.prototype.react Of course, since I implemented |
@mbland thanks for the context. im hoping to address this issue and help you remove your workaround soon! |
Is anyone still interested in a javascript port of hubot-slack? I'm in the process of modernizing Hubot and testing with this adapter, which doesn't work with Coffeescript 2. Thus finding myself at a cross roads. Does anyone still use this? |
@joeyguerra unfortunately not sorry |
Description
Porting the codebase to plain JavaScript
Hubot codebase moved away from CoffeeScript, is there any plan for hubot-slack?
Is it worth it to start working on it?
The text was updated successfully, but these errors were encountered: