Log when methods are deprecated

[wasabigeek]

Follow-up to #320 - log when a method is / will be deprecated.

There are some new methods that were added as well from the latest slack-api-ref, I'll open a new PR.

[dblock]

Add a spec similar to undocumented methods.

I think we have to decide whether the method is or will be deprecated. I would say "is". If the method stops working on a certain date we should extract that into slack-api-ref and add the message in the warning along the lines of "it will stop working on ...".

[wasabigeek]

What do you think about linking to the specific slack API instead, or copying the entire message? The deprecation warning actually has two dates e.g. https://api.slack.com/methods/channels.list

This method is deprecated. It will stop functioning in February 2021 and will not work with newly created apps after June 10th, 2020. Learn more.
Please use these methods instead:
conversations.list
users.conversations

[dblock]

What do you think about linking to the specific slack API instead, or copying the entire message? The deprecation warning actually has two dates e.g. https://api.slack.com/methods/channels.list

This method is deprecated. It will stop functioning in February 2021 and will not work with newly created apps after June 10th, 2020. Learn more.
Please use these methods instead:
conversations.list
users.conversations

Even better. I would use the message as is.

[wasabigeek]

There are some new methods picked up with the updated submodule, I haven't committed them - barring failed tests, will open a separate PR for them.

[dblock]

Check for a list of alternate methods here.

[dblock]

Needs a rubocop -a ; rubocop --auto-gen-config. Looks good!

[wasabigeek]

EDITED

Ok I managed to get by this offence by doing this:

        logger = instance_double(Logger)
        allow(client).to receive(:logger).and_return(logger)
        allow(client).to receive(:post)

        expect(logger).to receive(:warn).with(/
          ^channels\.archive:\ This\ method\ is\ deprecated
          .+
          Alternative\ methods:\ conversations\.archive\.
        /x)
        client.channels_archive(channel: 'test')

Do you think I should do so? If not, could we ignore these style cops completely :D

[dblock]

I think ignoring expectations is fine. I usually just -a everything and selectively fix if I feel like it.

[dblock]

Merged, thank you.