Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Missing translation for spanish in the popup.rename property in the Messages_es_ES.properties file #2254

Closed
1 of 3 tasks
drset opened this issue Aug 17, 2024 · 1 comment
Labels
bug GUI Issues in jadx-gui module

Comments

@drset
Copy link

drset commented Aug 17, 2024

Issue details

The right click contextual menu on open files is missing a translation for the Spanish language.

In the Messages_es_ES.properties file we can find the following line:
popup.rename=Nimeta ümber

It should be translated to spanish like this:
popup.rename=Renombrar

Jadx version

1.5.0

Java version

21.0.1

OS

  • Windows
  • Linux
  • macOS
@drset drset added bug GUI Issues in jadx-gui module labels Aug 17, 2024
@skylot
Copy link
Owner

skylot commented Aug 17, 2024

@drset thank you for report!
I commit a fix as you suggested.
Indeed, this line was added in PR #794 and according to Google translator this is actually is an Estonian, so looks like author of that PR mistakenly assume that ES in file name means Estonian (actual abbreviation is ET) instead Spanish 😢

@skylot skylot closed this as completed Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants