Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference to the window jQuery object is not set after script #61

Closed
binary-zero-one opened this issue Jul 5, 2021 · 2 comments
Closed

Reference to the window jQuery object is not set after script #61

binary-zero-one opened this issue Jul 5, 2021 · 2 comments

Comments

@binary-zero-one
Copy link

This issue is related to #21
It is specified that window.$ doesn't refer to the object after script, but also missed that window.jQuery itself is undefined too.
Image
Fix is to include one statement on line 22 after this line:
window.jQuery = keepRef;
soulgalore added a commit that referenced this issue Jul 5, 2021
@soulgalore
Set both JQuery refs back to normal #61
9130d9e
@soulgalore
Copy link
Member

Thank you @binary-zero-one let me push a new release tomorrow.

soulgalore added a commit that referenced this issue Jul 5, 2021
@soulgalore
Set both JQuery refs back to normal #61 (#62)
59cd339
@soulgalore
Copy link
Member

Released the updated version in sitespeed.io 17.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soulgalore @binary-zero-one