Reorder events dispatched in readyStateChange in FakeXMLHttpRequest
#722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`readyStateChange` function in `FakeXMLHttpRequest` are dispatched in a different order in comparison to a browser. Reorder the events dispatched to reflect general browser behaviour.
gavboulton
force-pushed
the
bugfix/event-dispatch-order
branch
from
7a51cdd to
435a888
Compare
|
I added and then removed a file and then pushed to force a new travis test. All tests passed. When removing the two commits to return this to the original PR the tests have gone back to their failed state. I think the first test just timed out so if you can re-run this the tests will pass. |
mroderick
added a commit
that referenced
this pull request
Apr 13, 2015
Reorder events dispatched in `readyStateChange` in `FakeXMLHttpRequest`
|
I triggered a new build in Travis, and all is green. Thanks! 👍 |
|
Awesome. Glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event listeners for
progress,loadandreadyStateChangefunction inFakeXMLHttpRequestare dispatched in a different order in comparison to a browser. Reorder the events dispatched to reflect general browser behaviour.Add a test to verify the dispatch order.