[PATCH] Fix issue #73 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmosca
force-pushed
the
fix-shadow-root-issue
branch
from
46a1630 to
f484a8f
Compare
joeldenning
approved these changes
Jun 30, 2023
|
Yes! Sorry if I didn't mention it in the description. I tested it multiple times and made sure the problem is present without this patch and disappears as soon as I apply this patch. |
robmosca
force-pushed
the
fix-shadow-root-issue
branch
from
f484a8f to
7e16460
Compare
TheMcMurder
approved these changes
Jul 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #73.
The problem is that the shadow element is create over and over again. This PR should fix it.