Upgrade xo #130
Upgrade xo #130
Conversation
| @@ -46,6 +46,7 @@ const resizeArrayBuffer = (contents, length) => { | |||
| return contents; | |||
| } | |||
|
|
|||
| // eslint-disable-next-line n/no-unsupported-features/es-syntax | |||
| const arrayBuffer = new ArrayBuffer(length, {maxByteLength: getNewContentsLength(length)}); | |||
There was a problem hiding this comment.
ArrayBuffer resizing is not supported in Node 18.
However, we check for support before calling this function.
| @@ -8,6 +8,7 @@ export class MaxBufferError extends Error { | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/ban-types | |||
| type TextStreamItem = string | Buffer | ArrayBuffer | ArrayBufferView; | |||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | |||
| export type AnyStream<SteamItem = TextStreamItem> = Readable | ReadableStream<SteamItem> | AsyncIterable<SteamItem>; | |||
There was a problem hiding this comment.
ReadableStream is supported in Node 18 but is marked as experimental.
However, it is a web standard, and the Node.js implementation has been pretty stable for a few years now.
This is only used in types, not runtime.
| @@ -5,6 +5,7 @@ import {finished} from 'node:stream/promises'; | |||
| export {fromAnyIterable as readableStreamFrom} from '@sec-ant/readable-stream/ponyfill'; | |||
|
|
|||
| export const createStream = streamDefinition => typeof streamDefinition === 'function' | |||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | |||
| ? Duplex.from(streamDefinition) | |||
There was a problem hiding this comment.
Duplex.from() is supported in Node 18 but is marked as experimental.
However, its implementation has barely changed in many years now. Also, this is only used in tests.
| @@ -63,13 +64,15 @@ if (!nodeVersion.startsWith('v16.')) { | |||
| test('works with readableWebStream({ type: "bytes" })', readableWebStream, 'bytes'); | |||
|
|
|||
| test('works with fetch()', async t => { | |||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | |||
| const {body} = await fetch(TEST_URL); | |||
There was a problem hiding this comment.
fetch() support is experimental in Node, but we're only using this in tests.
| const {body} = await fetch(TEST_URL); | ||
| const result = await getStream(body); | ||
| const parsedResult = JSON.parse(result); | ||
| t.true(Array.isArray(parsedResult)); | ||
| }); | ||
|
|
||
| test('can use TextDecoderStream', async t => { | ||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | ||
| const textDecoderStream = new TextDecoderStream('utf-16le'); |
There was a problem hiding this comment.
Same comment as for fetch(), but with TextDecoderStream().
| @@ -274,6 +274,7 @@ const testMultipleReads = async (t, wait) => { | |||
| assertSuccess(t, stream, Readable); | |||
| }; | |||
|
|
|||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | |||
| test('Handles multiple successive fast reads', testMultipleReads, () => scheduler.yield()); | |||
There was a problem hiding this comment.
Same comment as fetch(), but for scheduler.yield().
This PR upgrades xo.
CI currently failing due to actions/node-versions#182