Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-index: Fix for require() #436

Merged
merged 1 commit into from
Nov 14, 2019
Merged

import-index: Fix for require() #436

merged 1 commit into from
Nov 14, 2019

Conversation

garyking
Copy link
Contributor

When using ESLint to lint code while typing, if you type require() with the import-index rule enabled, then it will throw an error.

This fixes that.

@fisker
Copy link
Collaborator

fisker commented Nov 14, 2019

can you also check prevent-abbreviations?

@garyking
Copy link
Contributor Author

I haven't noticed any issues with prevent-abbreviations and require(), so it doesn't seem like any changes need to be made to those rule, or its tests.

@fisker
Copy link
Collaborator

fisker commented Nov 14, 2019

thanks

@sindresorhus sindresorhus changed the title import-index: Fix for require(). import-index: Fix for require() Nov 14, 2019
@sindresorhus sindresorhus merged commit 393e8e1 into sindresorhus:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants