custom-error-definition - Fix null reference (#188)

Fixes #150
sindresorhus · Sep 3, 2018 · cf3e22d · cf3e22d
1 parent f96dd97
commit cf3e22d
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 7 deletions.
diff --git a/rules/custom-error-definition.js b/rules/custom-error-definition.js
@@ -48,6 +48,10 @@ const customErrorDefinition = (context, node) => {
 		return;
 	}
 
+	if (node.id == null) {
+		return;
+	}
+
 	const {name} = node.id;
 	const className = getClassName(name);
 

diff --git a/test/custom-error-definition.js b/test/custom-error-definition.js
@@ -95,14 +95,22 @@ ruleTester.run('custom-error-definition', rule, {
 					this.name = 'FooError';
 				}
 			};
+		`,
+		`
+			exports.FooError = class extends Error {
+				constructor(error) {
+					super(error);
+				}
+			};
+		`,
 		`
-		// `
-		// 	exports.FooError = class extends Error {
-		// 		constructor(error) {
-		// 			super(error);
-		// 		}
-		// 	};
-		// `
+			exports.fooError = class extends Error {
+				constructor(error) {
+					super(error);
+					this.name = 'fooError';
+				}
+			};
+		`,
 	],
 	invalid: [
 		{
@@ -348,6 +356,20 @@ ruleTester.run('custom-error-definition', rule, {
 				invalidNameError('FooError')
 			]
 		},
+		// TODO: Uncomment test as part of #190
+		// {
+		// 	code: `
+		// 		exports.fooError = class FooError extends Error {
+		// 			constructor(error) {
+		// 				super(error);
+		// 				this.name = 'FooError';
+		// 			}
+		// 		};
+		// 	`,
+		// 	errors: [
+		// 		invalidNameError('fooError')
+		// 	]
+		// },
 		{
 			code: `
 				exports.FooError = class FooError extends TypeError {
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,6 +48,10 @@ const customErrorDefinition = (context, node) => { @@
     		return;
     	}
+    	if (node.id == null) {
+    		return;
+    	}
     	const {name} = node.id;
     	const className = getClassName(name);
@@ Expand Down @@