Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebContents to browserWindow TypeScript type #90

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Add WebContents to browserWindow TypeScript type #90

merged 1 commit into from
Feb 1, 2020

Conversation

ffflorian
Copy link
Contributor

As described in #65 (comment), it is possible to use webContents as window value. Tried locally and it works as expected.

@sindresorhus
Copy link
Owner

Can you add a test?

@ffflorian
Copy link
Contributor Author

@sindresorhus I added a test.

@sindresorhus sindresorhus changed the title fix: Add WebContents to browserWindow type Add WebContents to browserWindow TypeScript type Feb 1, 2020
@sindresorhus sindresorhus merged commit 1410532 into sindresorhus:master Feb 1, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
@atlslscsrv-app atlslscsrv-app mentioned this pull request Sep 7, 2024
Open
@atlslscsrv-app atlslscsrv-app mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffflorian @sindresorhus