Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python27 checks #255

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Remove python27 checks #255

merged 1 commit into from
Jul 26, 2023

Conversation

catap
Copy link
Contributor

@catap catap commented Jul 26, 2023

tcpflow since version 1.6.1 doesn't require nor use python anymore because the only plugin which is used it (scan_python.cpp) was excluded from build.

Anyway, the configure complains like:

  *** Cannot find python library.
  *** Please install python-devel to enable scanner python.
  ...
  configure: *** You have missing libraries. To install them:
  configure: *** Red Hat: sudo yum install  python-devel  python-devel
  configure: *** Fedora:  sudo dnf install  python-devel  python-devel
  configure: *** Ubuntu:  sudo apt-get install  libpython2.7-dev libpython2.7-dev
  configure: *** MacOS:   sudo port install  python27 python27

which is absolutley missleading anyone who tries to build it.

Here I've cleaned it up.

Copy link
Owner

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete lines rather than commenting them out.

configure.ac Outdated Show resolved Hide resolved
tcpflow since version 1.6.1 doesn't require nor use python anymore
because the only plugin which is used it (`scan_python.cpp`) was
excluded from build.

Anyway, the configure complains like:
```
  *** Cannot find python library.
  *** Please install python-devel to enable scanner python.
  ...
  configure: *** You have missing libraries. To install them:
  configure: *** Red Hat: sudo yum install  python-devel  python-devel
  configure: *** Fedora:  sudo dnf install  python-devel  python-devel
  configure: *** Ubuntu:  sudo apt-get install  libpython2.7-dev libpython2.7-dev
  configure: *** MacOS:   sudo port install  python27 python27
```
which is absolutley missleading anyone who tries to build it.

Here I've cleaned it up.

Closes: simsong#254
@catap catap changed the title Disable python27 checks Remove python27 checks Jul 26, 2023
@catap catap requested a review from simsong July 26, 2023 10:37
Copy link
Owner

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@simsong simsong self-assigned this Jul 26, 2023
catap added a commit to catap/macports-ports that referenced this pull request Jul 26, 2023
@simsong simsong merged commit f11eb8f into simsong:master Jul 26, 2023
@catap catap deleted the python27-tails branch July 26, 2023 10:43
reneeotten pushed a commit to macports/macports-ports that referenced this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants