Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PostCSS 8 #45

Merged
merged 2 commits into from
May 19, 2021
Merged

Update to PostCSS 8 #45

merged 2 commits into from
May 19, 2021

Conversation

onigoetz
Copy link
Contributor

Hello,

This PR makes the following changes, fixes #20

  • Update this module to PostCSS 8 using the migration guide : https://evilmartians.com/chronicles/postcss-8-plugin-migration
  • Update the node version to use 10 at the minimum
  • Remove the babel build step
  • Replace Jest with Mocha (way less dependencies to install, the advanced features of Jest aren't needed here)
  • Update TypeScript Typings
  • Add GitHub Actions

@Knagis
Copy link

Knagis commented May 19, 2021

FYI: https://www.npmjs.com/package/@notiv/postcss-property-lookup an existing fork of this plugin with PostCSS8 support.

@simonsmith
Copy link
Owner

@onigoetz Changes look good. Will merge and release when I get a free moment. Appreciate it

@simonsmith
Copy link
Owner

Only change I'd recommend is using yarn and removing the package-lock.json.

@onigoetz
Copy link
Contributor Author

Sure can do, I also prefer Yarn I just didn't want to introduce more changes than needed :)

@onigoetz
Copy link
Contributor Author

Oh, I missed that the yarn.lock already existed.
Change done

@simonsmith
Copy link
Owner

It looks like yarn.lock has been deleted in the diff?

@onigoetz
Copy link
Contributor Author

Yes it looks like it but actually it's just 2'000 lines shorter. if you load the diff you'll see there is still content.
The main reason is the removal of Babel and Jest.

@simonsmith
Copy link
Owner

Ah sorry, of course. My bad!

@simonsmith simonsmith merged commit ee8258a into simonsmith:master May 19, 2021
@simonsmith
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants