-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #170 Paypal rest extension #171
Closed
catharsisjelly
wants to merge
9
commits into
silverstripe:master
from
catharsisjelly:issue-170-paypal-rest-extension
+59
−0
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1d04cfc
Adding PayPal Rest extension
7859d95
Slight docuimentation tweek
55717d9
Added more docs
f04d233
Added properties to the Payment model for IDE goodness
4866109
Fixed typo
71a560d
Removing code that is no longer useful
6250dd6
Added Docblock and corrected typo
bf4f687
Removed unused includes
66a10cb
Added check for Rest Gateway
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added Docblock and corrected typo
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,11 +26,14 @@ public function onBeforePurchase(array &$gatewayData) | |
unset($gatewayData['card']); | ||
} | ||
|
||
/** | ||
* @param array $gatewayData | ||
*/ | ||
public function onBeforeCompletePurchase(array &$gatewayData) | ||
{ | ||
/** | ||
* As described in Omnipay\PayPal\Message\RestPurchaseRequest PayPal | ||
* responds from the payment withthe transaction reference and a | ||
* responds from the payment with the transaction reference and a | ||
* PayerID as GET vars. We gather tham and throw them back to PayPal | ||
* for confirmation | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code here should also be wrapped in a gateway check |
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tried this locally, and indeed, it seems to be a good idea to remove the card… since you'll be redirected to the offsite payment form anyway and according to the DocBlock, using a card is restricted to US and UK only.
You'd need to make sure this will only happen for the
PayPal_Rest
gateway though… eg. use something like: