Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #170 Paypal rest extension #171

Closed
wants to merge 9 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added Docblock and corrected typo
Chris Lock committed Jul 26, 2017
commit 6250dd6653ddc3cf571ecdee22c2be2c506fc8c4
5 changes: 4 additions & 1 deletion code/extensions/PayPalRestExtension.php
Original file line number Diff line number Diff line change
@@ -26,11 +26,14 @@ public function onBeforePurchase(array &$gatewayData)
unset($gatewayData['card']);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also tried this locally, and indeed, it seems to be a good idea to remove the card… since you'll be redirected to the offsite payment form anyway and according to the DocBlock, using a card is restricted to US and UK only.

You'd need to make sure this will only happen for the PayPal_Rest gateway though… eg. use something like:

if ($this->owner->getPayment()->Gateway === 'PayPal_Rest') {
    unset($gatewayData['card']);
}

}

/**
* @param array $gatewayData
*/
public function onBeforeCompletePurchase(array &$gatewayData)
{
/**
* As described in Omnipay\PayPal\Message\RestPurchaseRequest PayPal
* responds from the payment withthe transaction reference and a
* responds from the payment with the transaction reference and a
* PayerID as GET vars. We gather tham and throw them back to PayPal
* for confirmation
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here should also be wrapped in a gateway check