Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Reset password form improvements #35

Merged
merged 2 commits into from Jun 7, 2016
Merged

Reset password form improvements #35

merged 2 commits into from Jun 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2016

  • Added name to the form
  • Added 'has-error' to the form groups if the validation fails.
  • Used password-verify directive to check password matching
  • Passing isValid from the view to submit()

@ghost
Copy link
Author

ghost commented Jun 7, 2016

@silverbux can't seem to match your code style. What IDE you use? I'm using PhpStorm and I'm trying to get close to your styleguide.

Maybe add the good old CONTRIBUTING.md ? And specify what rules to follow and stuff like that

@silverbux
Copy link
Owner

silverbux commented Jun 7, 2016

yep acutally this one is good, i was referring to the other pull request #33

https://github.com/silverbux/laravel-angular-admin/pull/33/files#diff-8b7d3620a9180ec684527ab2753db7a7L6

re: CONTRIBUTING.md yeah will try to add html linting or at least a code style guide for HTML

@silverbux silverbux merged commit d8d2e02 into silverbux:master Jun 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants