Fix pkcs11ca with no cgo compilation bug #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was seeing this bug on my M1 when running `ko build .`, since `PKCS11CA` needs to be redefined for the no-cgo case: ``` ../fulcio/pkg/ca/pkcs11ca/pkcs11canocgo.go:26:2: undefined: baseca ``` Signed-off-by: Priya Wadhwa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
=======================================
Coverage 55.63% 55.63%
=======================================
Files 38 38
Lines 2333 2333
=======================================
Hits 1298 1298
Misses 939 939
Partials 96 96 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
haydentherapper
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was seeing this bug on my M1 when running
ko build ., sincePKCS11CAneeds to be redefined for the no-cgo case. The error was:We define
type PKCS11CA structfor the cgo case here, so this just does the same for the no-cgo case:fulcio/pkg/ca/pkcs11ca/pkcs11ca.go
Lines 39 to 41 in 81ecec8
Signed-off-by: Priya Wadhwa [email protected]