Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return SCT when a cert is generated #119

Closed
priyawadhwa opened this issue Jun 15, 2021 · 2 comments · Fixed by #163
Closed

Return SCT when a cert is generated #119

priyawadhwa opened this issue Jun 15, 2021 · 2 comments · Fixed by #163
Assignees

Comments

@priyawadhwa
Copy link
Contributor

We have this TODO to actually return the SCT when a cert is created:

//TODO: return SCT and SCT URL

If we started doing this, we could use the SCT to verify the cert is in the CT log. This would be the final piece of validation for cosign bundling to be finished!

@priyawadhwa
Copy link
Contributor Author

Not entirely sure if it would be OK to just change the API and return the SCT, right now we just return a string:

fulcio/openapi.yaml

Lines 48 to 51 in 39dcd1a

description: Generated Certificate Chain
schema:
type: string
400:

We could return the SCT as a JSON-encoded string and not have to change the API spec, but I don't love that option.

@bobcallaway
Copy link
Member

as soon as we have sigstore/sigstore#70 or sigstore/sigstore#69 resolved (which should be pretty soon) I'll push up a patch to include the SCT in the final certificate we issue.

@bobcallaway bobcallaway self-assigned this Jul 1, 2021
tommyd450 pushed a commit to tommyd450/fulcio that referenced this issue Apr 19, 2024
…main

🤖 [main] Update image version in Dockerfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants