Restict issuer claim mapping to email issuers (#606)

Using a claim other than "iss" to set the issuer on a certificate only makes sense for federating identity issuers like Dex. This restricts the issuers configued to this setting to email type issuers. Signed-off-by: Nathan Smith <[email protected]>
sigstore · May 23, 2022 · 47c38d6 · 47c38d6
1 parent 6bf9d30
commit 47c38d6
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 40 deletions.
diff --git a/pkg/challenges/challenges.go b/pkg/challenges/challenges.go
@@ -205,14 +205,9 @@ func spiffe(ctx context.Context, principal *oidc.IDToken) (identity.Principal, e
 		return nil, fmt.Errorf("spiffe ID trust domain %s doesn't match configured trust domain %s", parsedSpiffeID.TrustDomain(), trustDomain)
 	}
 
-	issuer, err := oauthflow.IssuerFromIDToken(principal, cfg.IssuerClaim)
-	if err != nil {
-		return nil, err
-	}
-
 	// Now issue cert!
 	return &ChallengeResult{
-		Issuer:  issuer,
+		Issuer:  principal.Issuer,
 		TypeVal: SpiffeValue,
 		Value:   spiffeID,
 		subject: spiffeID,
@@ -225,18 +220,8 @@ func kubernetes(ctx context.Context, principal *oidc.IDToken) (identity.Principa
 		return nil, err
 	}
 
-	cfg, ok := config.FromContext(ctx).GetIssuer(principal.Issuer)
-	if !ok {
-		return nil, errors.New("invalid configuration for OIDC ID Token issuer")
-	}
-
-	issuer, err := oauthflow.IssuerFromIDToken(principal, cfg.IssuerClaim)
-	if err != nil {
-		return nil, err
-	}
-
 	return &ChallengeResult{
-		Issuer:  issuer,
+		Issuer:  principal.Issuer,
 		TypeVal: KubernetesValue,
 		Value:   k8sURI,
 		subject: principal.Subject,
@@ -253,18 +238,8 @@ func githubWorkflow(ctx context.Context, principal *oidc.IDToken) (identity.Prin
 		return nil, err
 	}
 
-	cfg, ok := config.FromContext(ctx).GetIssuer(principal.Issuer)
-	if !ok {
-		return nil, errors.New("invalid configuration for OIDC ID Token issuer")
-	}
-
-	issuer, err := oauthflow.IssuerFromIDToken(principal, cfg.IssuerClaim)
-	if err != nil {
-		return nil, err
-	}
-
 	return &ChallengeResult{
-		Issuer:         issuer,
+		Issuer:         principal.Issuer,
 		TypeVal:        GithubWorkflowValue,
 		Value:          workflowRef,
 		AdditionalInfo: additionalInfo,
@@ -296,13 +271,8 @@ func uri(ctx context.Context, principal *oidc.IDToken) (identity.Principal, erro
 		return nil, fmt.Errorf("subject hostname (%s) must match expected domain (%s)", uSubject.Hostname(), uDomain.Hostname())
 	}
 
-	issuer, err := oauthflow.IssuerFromIDToken(principal, cfg.IssuerClaim)
-	if err != nil {
-		return nil, err
-	}
-
 	return &ChallengeResult{
-		Issuer:  issuer,
+		Issuer:  principal.Issuer,
 		TypeVal: URIValue,
 		Value:   uriWithSubject,
 		subject: uriWithSubject,
@@ -321,15 +291,10 @@ func username(ctx context.Context, principal *oidc.IDToken) (identity.Principal,
 		return nil, errors.New("invalid configuration for OIDC ID Token issuer")
 	}
 
-	issuer, err := oauthflow.IssuerFromIDToken(principal, cfg.IssuerClaim)
-	if err != nil {
-		return nil, err
-	}
-
 	emailSubject := fmt.Sprintf("%s@%s", username, cfg.SubjectDomain)
 
 	return &ChallengeResult{
-		Issuer:  issuer,
+		Issuer:  principal.Issuer,
 		TypeVal: UsernameValue,
 		Value:   emailSubject,
 		subject: username,

diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -204,6 +204,9 @@ func validateConfig(conf *FulcioConfig) error {
 	}
 
 	for _, issuer := range conf.OIDCIssuers {
+		if issuer.IssuerClaim != "" && issuer.Type != IssuerTypeEmail {
+			return errors.New("only email issuers can use issuer claim mapping")
+		}
 		if issuer.Type == IssuerTypeSpiffe {
 			if issuer.SPIFFETrustDomain == "" {
 				return errors.New("spiffe issuer must have SPIFFETrustDomain set")

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -285,6 +285,20 @@ func TestValidateConfig(t *testing.T) {
 			},
 			WantError: true,
 		},
+		"non email issuer with issuer claim set is invalid": {
+			Config: &FulcioConfig{
+				OIDCIssuers: map[string]OIDCIssuer{
+					"https://issuer.example.com": {
+						IssuerURL:         "htts://issuer.example.com",
+						ClientID:          "foo",
+						Type:              IssuerTypeSpiffe,
+						SPIFFETrustDomain: "example.com",
+						IssuerClaim:       "$.foo.bar",
+					},
+				},
+			},
+			WantError: true,
+		},
 		"nil config isn't valid": {
 			Config:    nil,
 			WantError: true,