Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light client updates by range RPC #6383

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Light client updates by range RPC #6383

merged 8 commits into from
Oct 18, 2024

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

Partially #3651

Proposed Changes

Enable light client updates request over RPC

@eserilev eserilev added light-client work-in-progress PR is a work-in-progress labels Sep 10, 2024
@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Sep 16, 2024
@jimmygchen jimmygchen self-requested a review October 3, 2024 20:22
jxs
jxs reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adapting to the changes I introduced Eitan! Left a comment

beacon_node/lighthouse_network/src/rpc/methods.rs Outdated Show resolved Hide resolved
dapplion
dapplion approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved for the 3rd time, maybe this one is the charm? :)

@dapplion dapplion requested review from michaelsproul and jxs October 16, 2024 13:59
jxs
jxs approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eitan, looks good to me now!

michaelsproul
michaelsproul approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole, just a few nits

beacon_node/lighthouse_network/src/rpc/methods.rs Outdated Show resolved Hide resolved
beacon_node/network/src/network_beacon_processor/rpc_methods.rs Show resolved Hide resolved
beacon_node/network/src/network_beacon_processor/rpc_methods.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. v6.0.0 New major release for hierarchical state diffs and removed ready-for-review The code is ready for review labels Oct 16, 2024
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 18, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Oct 18, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d1fda93

mergify bot added a commit that referenced this pull request Oct 18, 2024
@mergify
Merge of #6383
eb6c8b5
@mergify mergify bot mentioned this pull request Oct 18, 2024
Closed
5 tasks
@mergify mergify bot merged commit d1fda93 into sigp:unstable Oct 18, 2024
29 checks passed
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@eserilev @michaelsproul @chong-he
Light client updates by range RPC (sigp#6383)
38e7ac1 
* enable lc update over rpc

* resolve TODOs

* resolve merge conflicts

* move max light client updates to eth spec

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into light-client-updates-by-range-rpc

* remove ethspec dependency

* Update beacon_node/network/src/network_beacon_processor/rpc_methods.rs

Co-authored-by: Michael Sproul <[email protected]>

* Update beacon_node/lighthouse_network/src/rpc/methods.rs

Co-authored-by: Michael Sproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

@jxs jxs jxs approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
light-client ready-for-merge This PR is ready to merge. v6.0.0 New major release for hierarchical state diffs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eserilev @michaelsproul @jimmygchen @jxs @dapplion