Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data columns by root sync request #6274

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add data columns by root sync request #6274

merged 1 commit into from
Aug 21, 2024

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Part of

Proposed Changes

Add support inside sync network context to issue, track and complete data_columns_by_root requests.

This type of request will be issued by a higher order custody by root request. In summary:

  • Block lookup will trigger a custody by root request, code here: Add sync lookup custody request state #6257
  • Custody by root request will trigger data columns by root request(s): TODO
  • Data columns by root request complete: this PR

The handler of data_columns_by_root requests is quasi-identical to blobs_by_root request handler. Same verify conditions and completeness conditions.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling das-unstable-merge labels Aug 16, 2024
This was referenced Aug 16, 2024
Closed
Closed
pawanjay176
pawanjay176 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 20, 2024
@realbigsean
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Aug 20, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 677f96a

mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify
Merge of #6274
542983f
@mergify mergify bot mentioned this pull request Aug 20, 2024
Closed
5 tasks
@mergify mergify bot merged commit 677f96a into unstable Aug 21, 2024
52 of 53 checks passed
@mergify mergify bot deleted the peerdas-request-data-columns-by-root branch August 21, 2024 00:12
@jimmygchen jimmygchen restored the peerdas-request-data-columns-by-root branch August 21, 2024 02:38
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
@dapplion @AgeManning
Add data columns by root sync request (sigp#6274)
a13d96c 
* Add data columns by root sync request
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@dapplion @chong-he
Add data columns by root sync request (sigp#6274)
a95f2bc 
* Add data columns by root sync request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

@realbigsean realbigsean realbigsean approved these changes

@jimmygchen jimmygchen Awaiting requested review from jimmygchen

Assignees
No one assigned
Labels
das Data Availability Sampling das-unstable-merge ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dapplion @realbigsean @pawanjay176