Don't expect DAS config in HTTP spec response

[michaelsproul]

Issue Addressed

Lighthouse v5.3.0 RC validator clients unintentionally broke backwards compatibility with prior BNs due to some peer DAS fields that were considered mandatory in the /eth/v1/config/spec response:

ERRO Unable to read spec from beacon node endpoint: https://localhost:5052/, error: HttpClient(, kind: decode, detail: missing field CUSTODY_REQUIREMENT at line 1 column 4281)

Proposed Changes

• Add default annotations for the peer DAS fields of Config so the VC doesn't fail to decode responses that lack these fields. This is not necessarily a great approach, but it's what we've done for every fork so far. It might be nice to clean this up in future.

Additional Info

In future we could also remove the defaults for past forks.

[michaelsproul]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[jimmygchen]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

Rebasing this so we can re-run CI here on the PR until it succeeds, and then merge instantly

[michaelsproul]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Pull request #6221 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify dequeue

[mergify]

dequeue

✅ The pull request has been removed from the queue default

[michaelsproul]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Pull request #6221 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify refresh

[mergify]

refresh

✅ Pull request refreshed

[michaelsproul]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Pull request #6221 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 42a1cd8