-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit peers #5333
Explicit peers #5333
Conversation
@mempirate - Thanks for the PR. You've caught us at a time where we are actively going through and removing old/deprecated and non-critical CLI flags, as we've had a few complaints of there being too many. How do you feel about just using the trusted-peers CLI flag. i.e all trusted peers become explicit peers on the gossipsub level. I think this what should have been implemented when we added the trusted-peers flag. |
@AgeManning I think that also makes sense as an approach! Agreed that there's a lot of overlapping functionality. Done in following commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for the addition!
Also, in the future, we can always change the base of the PR, no need to make a new one :)
(I know this, because I accidentally do it all the time 😅 )
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 641f6be |
Issue Addressed
Closes #5268
Proposed Changes
This PR implements explicit peering agreements (https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#explicit-peering-agreements). It was decided not to add a separate
--explicit-peers
flag, but instead instantiate trusted peers as explicit. This means that when a trusted peer is defined, it will have the following properties: