Remove best just checkpoint from EF tests

sigp · Feb 10, 2023 · 6fbf9e4 · 6fbf9e4
1 parent 2349e80
commit 6fbf9e4
Showing 1 changed file with 0 additions and 15 deletions.
diff --git a/testing/ef_tests/src/cases/fork_choice.rs b/testing/ef_tests/src/cases/fork_choice.rs
@@ -45,7 +45,6 @@ pub struct Checks {
     justified_checkpoint: Option<Checkpoint>,
     justified_checkpoint_root: Option<Hash256>,
     finalized_checkpoint: Option<Checkpoint>,
-    best_justified_checkpoint: Option<Checkpoint>,
     u_justified_checkpoint: Option<Checkpoint>,
     u_finalized_checkpoint: Option<Checkpoint>,
     proposer_boost_root: Option<Hash256>,
@@ -229,7 +228,6 @@ impl<E: EthSpec> Case for ForkChoiceTest<E> {
                         justified_checkpoint,
                         justified_checkpoint_root,
                         finalized_checkpoint,
-                        best_justified_checkpoint,
                         u_justified_checkpoint,
                         u_finalized_checkpoint,
                         proposer_boost_root,
@@ -260,11 +258,6 @@ impl<E: EthSpec> Case for ForkChoiceTest<E> {
                         tester.check_finalized_checkpoint(*expected_finalized_checkpoint)?;
                     }
 
-                    if let Some(expected_best_justified_checkpoint) = best_justified_checkpoint {
-                        tester
-                            .check_best_justified_checkpoint(*expected_best_justified_checkpoint)?;
-                    }
-
                     if let Some(expected_u_justified_checkpoint) = u_justified_checkpoint {
                         tester.check_u_justified_checkpoint(*expected_u_justified_checkpoint)?;
                     }
@@ -575,14 +568,6 @@ impl<E: EthSpec> Tester<E> {
         check_equal("finalized_checkpoint", fc_checkpoint, expected_checkpoint)
     }
 
-    /// This test is now a no-op since it was removed by Aditya's PR #18.
-    pub fn check_best_justified_checkpoint(
-        &self,
-        _expected_checkpoint: Checkpoint,
-    ) -> Result<(), Error> {
-        Ok(())
-    }
-
     pub fn check_u_justified_checkpoint(
         &self,
         expected_checkpoint: Checkpoint,