-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PromisePoolCluster.of
returns PromisePoolCluster
instead of PoolNamespace
#3261
base: master
Are you sure you want to change the base?
fix: PromisePoolCluster.of
returns PromisePoolCluster
instead of PoolNamespace
#3261
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3261 +/- ##
==========================================
+ Coverage 88.45% 88.65% +0.20%
==========================================
Files 83 83
Lines 13067 13116 +49
Branches 1393 1417 +24
==========================================
+ Hits 11558 11628 +70
+ Misses 1509 1488 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # test/esm/integration/pool-cluster/test-promise-wrapper.test.mjs
Test added. |
PromisePoolCluster.of
returns PromisePoolCluster
instead of PoolNamespace
38c64fe
to
9c0c292
Compare
Hey @jcmartineztiempo, thanks! Also, sorry for the lack of infos or support, December is usually very hectic 😅 |
Hi @wellwelwel, Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later. Don't worry about support...it's my first ever pool request!! |
Fixes #3091.