fix: PromisePoolCluster.of returns PromisePoolCluster instead of PoolNamespace
#3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3261 +/- ##
==========================================
+ Coverage 88.45% 88.65% +0.20%
==========================================
Files 83 83
Lines 13067 13116 +49
Branches 1393 1417 +24
==========================================
+ Hits 11558 11628 +70
+ Misses 1509 1488 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # test/esm/integration/pool-cluster/test-promise-wrapper.test.mjs
|
Test added. |
wellwelwel
changed the title
PromisePoolCluster.of returns PromisePoolCluster instead of PoolNamespace
jcmartineztiempo
force-pushed
the
hotfix/fix_3091
branch
from
38c64fe to
9c0c292
Compare
|
Hey @jcmartineztiempo, thanks! Also, sorry for the lack of infos or support, December is usually very hectic 😅 |
|
Hi @wellwelwel, Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later. Don't worry about support...it's my first ever pool request!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3091.