feat: add quit shortcut #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to quit the application using Ctrl-q
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to quit the application using Ctrl-q. Also see: #23.
As you pointed out correctly, the HIG doesn't enforce this shortcut, or at least not in case an application doesn't implement (other) shortcuts. However, I would still say that this way, the app feels more like a Gnome app, and fits better with the standard Gnome workflow. So, there's a pretty okay reason to implement this 🙂
Moreover, Luminance is an app that you don't need or want to stay in for a long time. This change facilitates that use case by allowing users to apply their muscle memory.
I understand not wanting to grow the codebase, but the change is fairly small.