Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure :json_put exists as well! #1

Open
wants to merge 26 commits into
base: json-requests
Choose a base branch
from

Conversation

bobber205
Copy link

No description provided.

FabienChaynes and others added 25 commits June 11, 2018 06:20
…k#919)

* Accepts cursor that now has string format and last page cursor is blank

* added direct message events endpoint

* build direct message object on direct message event

* fix test

* improve documentation

* code formatting conform

* added sender_id and recipient_id on direct message object
* Support closing stream

In this version, we can close stream as following:

```ruby
client = Twitter::Streaming::Client.new do |config|
  # Set up configuration
end

t = Thread.new do
  client.filter(track: keyword) do |object|
    # process object
  end
end

Signal.trap(:TERM) do
  # terminate process silently
  client.close
  exit true
end
```

* Add Twitter::Streaming::Connection#stream spec

* Wait for connection

* Suppress rubocop warning

    lib/twitter/streaming/connection.rb:17:7: C: Method has too many lines. [13/10]
          def stream(request, response) ...
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* Use port number 8443 instead of 11443

Because rubocop reports following warnings:

    spec/twitter/streaming/connection_spec.rb:88:48: C: Use underscores(_) as decimal mark and separate every 3 digits with them.
        let(:client) {  TCPSocket.new('127.0.0.1', 11443) }
                                                   ^^^^^
    spec/twitter/streaming/connection_spec.rb:94:44: C: Use underscores(_) as decimal mark and separate every 3 digits with them.
          @server = TCPServer.new('127.0.0.1', 11443)
                                               ^^^^^
…ik#823)

This makes consumption of the Twitter::NullObject easier in Rails
projects.
* Add upload by chunks to big size gifs

* Add specs to this particular case
* Update endpoint for direct_messages_received

* Update endpoint for direct_messages_sent

* Update endpoint for direct_message show

* Update endpoint for destroying direct message

* Update endpoint for creating direct message

* Fix created_at format for direct message from dm event

* Clean up

* Add limit feature for cursor

Add map method to enumerable

* Rubocop/Code Climate fixes

* Change created_at to allow it to receive a Time object

* Add missing documentation
Updating my gem to 6.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.