forked from sferik/twitter-ruby
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure :json_put exists as well! #1
Open
bobber205
wants to merge
26
commits into
shmargum:json-requests
Choose a base branch
from
bobber205:json-requests
base: json-requests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k#919) * Accepts cursor that now has string format and last page cursor is blank * added direct message events endpoint * build direct message object on direct message event * fix test * improve documentation * code formatting conform * added sender_id and recipient_id on direct message object
* Support closing stream In this version, we can close stream as following: ```ruby client = Twitter::Streaming::Client.new do |config| # Set up configuration end t = Thread.new do client.filter(track: keyword) do |object| # process object end end Signal.trap(:TERM) do # terminate process silently client.close exit true end ``` * Add Twitter::Streaming::Connection#stream spec * Wait for connection * Suppress rubocop warning lib/twitter/streaming/connection.rb:17:7: C: Method has too many lines. [13/10] def stream(request, response) ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ * Use port number 8443 instead of 11443 Because rubocop reports following warnings: spec/twitter/streaming/connection_spec.rb:88:48: C: Use underscores(_) as decimal mark and separate every 3 digits with them. let(:client) { TCPSocket.new('127.0.0.1', 11443) } ^^^^^ spec/twitter/streaming/connection_spec.rb:94:44: C: Use underscores(_) as decimal mark and separate every 3 digits with them. @server = TCPServer.new('127.0.0.1', 11443) ^^^^^
…ik#823) This makes consumption of the Twitter::NullObject easier in Rails projects.
* Add upload by chunks to big size gifs * Add specs to this particular case
* Update endpoint for direct_messages_received * Update endpoint for direct_messages_sent * Update endpoint for direct_message show * Update endpoint for destroying direct message * Update endpoint for creating direct message * Fix created_at format for direct message from dm event * Clean up * Add limit feature for cursor Add map method to enumerable * Rubocop/Code Climate fixes * Change created_at to allow it to receive a Time object * Add missing documentation
Updating my gem to 6.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.