Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60 bug logging for container registry #61

Merged
merged 2 commits into from
Oct 30, 2024
Merged

60 bug logging for container registry #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514fda2
fix(models): added logging
shinybrar Oct 30, 2024
1e96c68
style(lint): mistakes
shinybrar Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

```python
from skaha.models import ContainerRegistry

registry = ContainerRegistry()
```

Expand Down
7 changes: 6 additions & 1 deletion skaha/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
from pydantic import BaseModel, ConfigDict, Field, field_validator, model_validator
from typing_extensions import Self

from skaha.utils import logs

log = logs.get_logger(__name__)

KINDS = Literal["desktop", "notebook", "carta", "headless"]
STATUS = Literal["Pending", "Running", "Terminating", "Succeeded", "Error"]
VIEW = Literal["all"]
Expand Down Expand Up @@ -161,7 +165,8 @@ def _check_secret(cls, value: str) -> str:
str: Validated value.
"""
if not value:
environ.get("SKAHA_REGISTRY_SECRET", None)
value = environ.get("SKAHA_REGISTRY_SECRET", None) # type: ignore
log.info("Using SKAHA_REGISTRY_SECRET from environment")
assert value, "secret is required"
return value

Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading