Merge pull request #61 from shinybrar/60-bug-logging-for-container-re…

…gistry 60 bug logging for container registry
shinybrar · Oct 30, 2024 · 03dad64 · 03dad64
2 parents e7dbac2 + 1e96c68
commit 03dad64
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/docs/index.md b/docs/index.md
@@ -22,6 +22,7 @@
 
     ```python
     from skaha.models import ContainerRegistry
+
     registry = ContainerRegistry()
     ```
 

diff --git a/skaha/models.py b/skaha/models.py
@@ -7,6 +7,10 @@
 from pydantic import BaseModel, ConfigDict, Field, field_validator, model_validator
 from typing_extensions import Self
 
+from skaha.utils import logs
+
+log = logs.get_logger(__name__)
+
 KINDS = Literal["desktop", "notebook", "carta", "headless"]
 STATUS = Literal["Pending", "Running", "Terminating", "Succeeded", "Error"]
 VIEW = Literal["all"]
@@ -161,7 +165,8 @@ def _check_secret(cls, value: str) -> str:
             str: Validated value.
         """
         if not value:
-            environ.get("SKAHA_REGISTRY_SECRET", None)
+            value = environ.get("SKAHA_REGISTRY_SECRET", None)  # type: ignore
+            log.info("Using SKAHA_REGISTRY_SECRET from environment")
         assert value, "secret is required"
         return value
 

diff --git a/uv.lock b/uv.lock
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,6 +22,7 @@ @@
         ```python
         from skaha.models import ContainerRegistry
         registry = ContainerRegistry()
         ```
@@ Expand Down @@