fix(cli): Normalize globby path for cli build command #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
This PR contains:
Are tests included?
I used the existing test suite and did not make any new tests
Breaking Changes?
List any relevant issue numbers:
resolves #41
Description
As discussed in #41, the jsx-email's CLI
build
command useglobby
to search for file names to read, build, and write to. However, per sindresorhus/globby#179, on Windows system, Globby won't work as Windows path contains backslashes but Globby only wants path with forward slashes.Therefore, a
normalizePath
function (inspired by rollup) was used to normalize the path so it would work on both Windows and UNIX systems