🐛 Fix closed check when handling querySubscribe()
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Agent` attempts to check if it's been closed when getting the response for a query subscribe. However, it incorrectly tries to access `this` inside a `function`, which doesn't give the correct value, and in `strict mode`, will actually result in an error, since `this` will be `undefined`. This change adds a test for this case and fixes it.
ericyhwang
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Agentattempts to check if it's been closed when getting the response for a query subscribe.However, it incorrectly tries to access
thisinside afunction, which doesn't give the correct value, and instrict mode, will actually result in an error, sincethiswill beundefined.This change adds a test for this case and fixes it.