Add tags to role model #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2023 18:52
Dakurei
approved these changes
Jun 27, 2023
Co-authored-by: Dakurei <[email protected]>
Co-authored-by: Dakurei <[email protected]>
Co-authored-by: Dakurei <[email protected]>
|
Thanks for review @Dakurei. All suggestions were applied |
Dakurei
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Personally, it looks fine to me, I don't have access to roles with "integration_id", "subscription_listing_id", "available_for_purchase" and "guild_connections" tags to check absolutely everything in terms of the content returned, but there's no reason for any problems 👍
I'll pass the baton to anyone who wants to check this out in more detail !
|
Cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added a wrapper class for the Discord role's tags and added the tags field to the role model as it wasn't possible to access the role tags data (e.g. role's bot ID) while using the server role created/updated/deleted gateway event payload.
Added
Discordrb::Role::TagsclassChanged
Discordrb::Role#tagsattribute