Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disconnect user from a voice channel via the Server#move method #226

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Allow disconnect user from a voice channel via the Server#move method #226

merged 2 commits into from
Jun 13, 2023

Conversation

Dakurei
Copy link
Contributor

@Dakurei Dakurei commented Jun 7, 2023

Summary

It's all in the title
Allows to fix issue #185

Changed

  • Server#move accept nil for channel param

anna328p
anna328p suggested changes Jun 7, 2023
View reviewed changes
Copy link

@anna328p anna328p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/discordrb/data/server.rb Outdated Show resolved Hide resolved
@swarley swarley merged commit 984826c into shardlab:main Jun 13, 2023
@Dakurei Dakurei deleted the allow_kick_from_voice_channels branch June 14, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna328p anna328p anna328p approved these changes

@swarley swarley swarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dakurei @swarley @anna328p