New usernames system #221
Merged
New usernames system #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add User#display_name + Change User#distinct to use discriminator or not, depend to the context (Maybe need change method later, next API versions may remove the discriminator field) + Change Discordrb::API::User#default_avatar & User#avatar_url to use old method to calculate index or not, depend to legacy or not (Maybe need change method later, next API versions may remove the discriminator field) + Change Member#display_name to select global_name before username, but after server nickname + Change Webhook#avatar_url to use new method to calculate index (After testing the webhook creation, the ID already seems to be used for the default avatar instead of the discriminator at 0000)
+ Without relying on a 0000 discrimator, since it is very likely that this field will disappear completely, sooner or later
+ As I saw that the 'ACTIVE_DEVELOPER' flag was missing in the documentation, I added it in the process.
|
Any chance this can go in soon? |
swarley
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added the new 'global_name' field that would be interesting to have for bots, as well as modified 2-3 mechanics of some methods to keep some kind of consistency with what Discord is displaying since this transition period with the new usernames.
I didn't touch anything concerning the updating of this field from the bot, I only did the reading.
I voluntarily left some TODOs lying around since I'm not sure of anything about the direction the API modification is going to take, and I had to search in the github of their docs (discord/discord-api-docs#6130) since the deployed one is still not up to date concerning this new system...
I also tried to get rid of the dependency on the 0000 discriminator to determine if a user is a webhook
And I added a missing flag while I was at it.
Added
Changed
Removed