Use Docker executor in CI for deploying docs #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not specifying a machine image defaults to using a Trusty image, which is deprecated and will soon fail. Assuming this works correctly, it seems like using a Docker executor is preferable anyway. (see https://circleci.com/blog/ubuntu-14-16-image-deprecation/)
This is necessary because we use a custom checkout step when deploying docs. CircleCI's built-in `checkout` step does this automatically.
PanisSupraOmnia
force-pushed
the
circleci-machine-image
branch
from
d1ad562 to
0170a3c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As noted in #136 CircleCI is deprecating its 14.04/16.04 images. This PR resolves #136 by switching to a Docker executor in the docs deploy step, where we were previously using the default
machineexecutor.Changed