Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Interaction): serialize embeds in respond #121

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

swarley
Copy link
Member

@swarley swarley commented Jan 16, 2022

Summary

Embeds passed as parameters to interaction methods were not properly serialized. This PR unifies builder preparation to ensure the embed builder is responsible for creating the payload.


Added

Interaction#prepare_builder - private method for adding information passed as parameters.

Fixed

Interaction methods all serialize embeds passed via parameters properly.

@swarley swarley added the bug Something isn't working label Jan 16, 2022
@swarley swarley changed the title Fix/serialize embeds in respond fix(Interaction): serialize embeds in respond Jan 16, 2022
@swarley swarley merged commit 8feaee5 into shardlab:main Jan 16, 2022
@swarley swarley deleted the fix/serialize-embeds-in-respond branch January 16, 2022 17:09
@Daniel-Worrall Daniel-Worrall added the interactions Deals with interactions or slash commands label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interactions Deals with interactions or slash commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants