-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/test install script #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to enable the running of this script in ci
BelfordZ
force-pushed
the
feat/test-install-script
branch
from
September 19, 2024 19:50
0d71f53
to
b787d40
Compare
BelfordZ
force-pushed
the
feat/test-install-script
branch
from
September 19, 2024 19:52
b787d40
to
9bf7772
Compare
BelfordZ
force-pushed
the
feat/test-install-script
branch
from
September 19, 2024 20:36
c522453
to
b138789
Compare
I just bumped the version of the checkout action in the new workflow to clear out some deprecation warnings and. it looks like that worked so i'll approve and merge this in a sec |
i'm bypassing this, i approve but it's not letting me approve now since i made changes but the changes are minor enough it doesn't really matter |
Giving my retroactive approval 👍 |
BelfordZ
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces several improvements to the validator-dashboard installer script to enhance usability, error handling, and compatibility for both interactive and non-interactive environments, especially in CI/CD pipelines such as GitHub Actions.
Key Updates:
Support for Non-Interactive Execution:
Improved Error Handling:
Docker Image Build Improvements:
SSL Handling in Curl Requests:
curl
with the-k
option, which allows bypassing SSL verification issues (e.g., self-signed certificates) for testing environments.curl
is used with-f
and-k
in combination to fail gracefully on HTTP errors while ignoring SSL certificate problems.Directory Setup and Feedback:
.env
file and building Docker images.Benefits: