Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binaries): Bring PyPi package size under the limit #192

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(binaries): Bring PyPi package size under the limit #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions binaries/build_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,12 @@
# The download links to each binary. These download links aren't complete.
# They are missing the platfrom-specific suffix and optional distro-specific
# suffix (Linux only).
FFMPEG_BINARIES_DL = [
DISTRO_BINARIES_DL = [
FFMPEG_DL_PREFIX + '/ffmpeg',
FFMPEG_DL_PREFIX + '/ffprobe',
]
PACKAGER_BINARIES_DL = [
# These don't have distro-specific suffixes on Linux.
NON_DISTRO_BINARIES_DL = [
FFMPEG_DL_PREFIX + '/ffprobe',
PACKAGER_DL_PREFIX + '/packager',
]
# Important: wrap map() in list(), because map returns an iterator, and we need
Expand Down Expand Up @@ -123,15 +124,15 @@ def main():

# Use the suffix specific to this platfrom to construct the full download
# link for each binary.
for binary_dl in PACKAGER_BINARIES_DL:
for binary_dl in NON_DISTRO_BINARIES_DL:
download_link = binary_dl + suffix
binary_name = download_binary(download_url=download_link,
download_dir=download_dir)
binaries_to_include.append(binary_name)

# FFmpeg binaries are like packager binaries, except we have extra variants
# for Ubuntu Linux to support hardware encoding.
for binary_dl in FFMPEG_BINARIES_DL:
# FFmpeg binaries have extra variants for Ubuntu Linux to support hardware
# encoding.
for binary_dl in DISTRO_BINARIES_DL:
download_link = binary_dl + suffix
binary_name = download_binary(download_url=download_link,
download_dir=download_dir)
Expand Down
1 change: 0 additions & 1 deletion binaries/streamer_binaries/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,3 @@
if distro.version() in _ubuntu_versions_with_hw_encoders:
suffix = '-ubuntu-' + distro.version()
ffmpeg += suffix
ffprobe += suffix