Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for FLAC codec #187

Merged
merged 5 commits into from
Nov 6, 2024
Merged

feat: Add support for FLAC codec #187

merged 5 commits into from
Nov 6, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 5, 2024

No description provided.

@avelad avelad added the type: enhancement New feature or request label Nov 5, 2024
joeyparrish
joeyparrish reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to merge #189, retest and merge #188, then retest and merge this.

After all of those are merged, I want to release 1.0.0.

@avelad avelad requested a review from joeyparrish November 6, 2024 08:51
mariocynicys
mariocynicys approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@avelad avelad merged commit 2edfefe into shaka-project:main Nov 6, 2024
13 checks passed
@avelad avelad deleted the flac branch November 6, 2024 09:17
@shaka-bot shaka-bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @joeyparrish @mariocynicys