fix(binaries): Bring PyPi package size under the limit #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://pypi.org/help/#file-size-limit, there is a limit of 100MB for any given wheel. Our Linux x64 wheel is 101MB, and so the 1.0.0 release failed to upload. This reduces the binary size by avoiding distro-specific versions of ffprobe. The only thing we get from distro-specific versions of ffmpeg is hardware-encoding support, but that doesn't apply to ffprobe. So it was wasteful to include distro-specific ffprobe builds. This reduces the Linux x64 wheel size from 101MB to 69MB.
avelad
approved these changes
Nov 6, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2024-11-06) ### Bug Fixes * **binaries:** Bring PyPi package size under the limit ([#192](#192)) ([3de6706](3de6706)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://pypi.org/help/#file-size-limit, there is a limit of 100MB for any given wheel. Our Linux x64 wheel is 101MB, and so the 1.0.0 release failed to upload.
This reduces the binary size by avoiding distro-specific versions of ffprobe. The only thing we get from distro-specific versions of ffmpeg is hardware-encoding support, but that doesn't apply to ffprobe. So it was wasteful to include distro-specific ffprobe builds.
This reduces the Linux x64 wheel size from 101MB to 69MB.