perf: Reduce calls to isTypeSupported #7729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: performance
|
Incremental code coverage: 91.67% |
tykus160
approved these changes
Dec 9, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Dec 11, 2024
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType
joeyparrish
pushed a commit
that referenced
this pull request
Dec 11, 2024
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType
joeyparrish
pushed a commit
that referenced
this pull request
Dec 11, 2024
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType Release-As: 4.9.2-caf3
joeyparrish
pushed a commit
that referenced
this pull request
Dec 12, 2024
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType
joeyparrish
pushed a commit
that referenced
this pull request
Dec 12, 2024
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should not be any call to isTypeSupported if we have already used Mcap with the same codecs/mimeType